Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParBlocksSizeUser impls #317

Closed
wants to merge 3 commits into from
Closed

Conversation

rozbb
Copy link

@rozbb rozbb commented Apr 29, 2022

This impls ParBlocksSizeUser for AES and Kuznyechik block ciphers. ParBlocksSizeUser was already impl'd for their backends, so this was a matter of copy-pasting.

This unblocks the fix for RustCrypto/AEADs#410

@newpavlov
Copy link
Member

No, it's meaningless to implement ParBlocksSizeUser on ciphers themselves. If you need access to explicit parallel block processing, then you SHOULD use the with_backend methods.

@tarcieri
Copy link
Member

@newpavlov can you take a look at RustCrypto/AEADs#410 ?

None of us can figure out how to properly do the upgrade.

@newpavlov
Copy link
Member

@tarcieri Yes, I will try to do it this weekend.

@tomtau
Copy link

tomtau commented May 26, 2022

Hi @newpavlov, a gentle nudge on this. Or would you need any help?

@tarcieri
Copy link
Member

Seems this is not necessary

@tarcieri tarcieri closed this Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants